Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFP: Support native ads #22

Open
milkovsky opened this issue Mar 16, 2018 · 10 comments
Open

DFP: Support native ads #22

milkovsky opened this issue Mar 16, 2018 · 10 comments

Comments

@milkovsky
Copy link

milkovsky commented Mar 16, 2018

Currently every ad is embedded as an iframe.
There is also a possibility to ad native "fluid" ads in DFP.
Currently "fluid" size is not supported as well.
See: https://support.google.com/dfp_premium/answer/7438314

@milkovsky
Copy link
Author

Examples: http://dfp-native-demo.appspot.com/2

@mxhCodes
Copy link
Contributor

So we basically only need the possibility to add 'fluid' into the text field for ad sizes, right?

@mxhCodes
Copy link
Contributor

I'll have a look at it

@milkovsky
Copy link
Author

I have tried adding fluid to the sizes. But it anyway renders an iframe in the end. Looks like we should add a new view handler.

@jintnc
Copy link

jintnc commented Mar 16, 2018

according to HJP from burda studios, DFP's native ads can't be shown in an iframe, here is his article/workaround for "Bunte":
http://insights.burda-studios.de/howto-run-fully-responsive-doubleclick-native-ads-without-iframes/

@mxhCodes
Copy link
Contributor

I think we talk about two separate things here:

  • Support for native ads and
  • Custom rendering

According to https://support.google.com/dfp_premium/answer/6366910?hl=en native ads are always being rendered as "SafeFrames" by default for web apps, which are iframes in the end. This is basically what the "default HTML view" currently does.

Conclusion: We need to

  • add the possibility to add 'fluid' as a valid size to DFP ads and
  • create a new View handler plugin for custom rendering.
    I'm curious though how we'd accomplish the custom rendering to be commonly useful. It looks like a customized use case and its implementation seems to vary on the project's needs, no?

@milkovsky
Copy link
Author

ok. it looks like fluid should be enough.
the http://dfp-native-demo.appspot.com/2 demo uses iframes as well.

@mxhCodes
Copy link
Contributor

mxhCodes commented Mar 16, 2018

Ok, let's use this issue regards native ads support only, and optionally create a new on regards custom rendering. Issue for custom rendering: #23

@mxhCodes mxhCodes changed the title Support native ads for DFP DFP: Support native ads Mar 16, 2018
mxhCodes pushed a commit that referenced this issue Mar 16, 2018
@mxhCodes
Copy link
Contributor

Please try and let me know if 7361f23 is working for you.

@milkovsky
Copy link
Author

Works great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants