-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DFP: Support native ads #22
Comments
Examples: http://dfp-native-demo.appspot.com/2 |
So we basically only need the possibility to add 'fluid' into the text field for ad sizes, right? |
I'll have a look at it |
I have tried adding fluid to the sizes. But it anyway renders an iframe in the end. Looks like we should add a new view handler. |
according to HJP from burda studios, DFP's native ads can't be shown in an iframe, here is his article/workaround for "Bunte": |
I think we talk about two separate things here:
According to https://support.google.com/dfp_premium/answer/6366910?hl=en native ads are always being rendered as "SafeFrames" by default for web apps, which are iframes in the end. This is basically what the "default HTML view" currently does. Conclusion: We need to
|
ok. it looks like fluid should be enough. |
Ok, let's use this issue regards native ads support only, and optionally create a new on regards custom rendering. Issue for custom rendering: #23 |
Please try and let me know if 7361f23 is working for you. |
Works great, thanks! |
Currently every ad is embedded as an iframe.
There is also a possibility to ad native "fluid" ads in DFP.
Currently "fluid" size is not supported as well.
See: https://support.google.com/dfp_premium/answer/7438314
The text was updated successfully, but these errors were encountered: