-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should bbox diagonal refer to vertices or sites? #18
Comments
Does this mean the vertices bbox is in your case smaller than the minimum bounding geometry of the sites? I think it is good to compute the bbox diagonal in relation to the vertices, because these are the "observations" we want to interpolate. |
I get the point. This issue should be at least mentioned in our documentation as an option. But i hesitate to change the code due to the fact that this will impact the results of the sample application. Have you compared the results of the sample app using the sites bbox instead of the vertices bbox? |
In the case of the example application, this problem does not occur because there is a vertex of the Voronoi diagram on each of the four sides of the
|
Hi again, Sorry for spreading my comments all over the place. I would like to give the kriging a try by changing the deldir to include a 10% size increase. How and where should I adjust the code to give this a try? Like I mentioned in one of other threads. Although increasing the size might add problems in terms of adding more data locations for kriging, a limited size might also skew the calculations relating to the increase of space or the percentage coverage, as isolines that intersect with the edges of the kriging raster will (at least in QGIS) be converted to polygons erroneously. |
Have a look at issue #16. You have to drop the rw-parameter in the deldir-Function:
|
Ok! I gave this a try. calculate vertices of voronoi diagramvoronoi_vertices <- deldir::deldir(sites@coords[, 1], However, then right after when I try to extract the voronoi vertices at: extraction of verticesdirsgs I get the following error:
I suppose I'm missing something when creating the voronois? |
The length of the diagonal of the bbox, which is required to determine the lag distance, is calculated on the basis of the vertices of the Voronoi diagram. In individual cases, this does not match the bounding box of the archaeological sites (determined by
deldir::deldir
), since vertices are not necessarily located on all sides of the rectangle.This also applies to the calculation of the kriging grid.
Should we adjust the calculation of the bbox diagonal and the Kriging grid to the rectangle created by
deldir::deldir
?The text was updated successfully, but these errors were encountered: