Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support fo magic javascript #509

Closed
danieleguido opened this issue Jan 24, 2023 · 1 comment · Fixed by #510
Closed

add support fo magic javascript #509

danieleguido opened this issue Jan 24, 2023 · 1 comment · Fixed by #510

Comments

@danieleguido
Copy link
Collaborator

See issue C2DH/journal-of-digital-history-jupyter-stack#7

The magic javascript is going to be deprecated it seems:
https://ipython.readthedocs.io/en/stable/interactive/magics.html#cellmagic-javascript

There is a javascript extension, too, on JupyterLab:
https://www.npmjs.com/package/@jupyterlab/javascript-extension
@danieleguido danieleguido mentioned this issue Jan 24, 2023
Merged
@eliselavy
Copy link
Collaborator

In myBinder:

danieleguido added a commit that referenced this issue Jan 25, 2023
@danieleguido
Fix/issue 509 magic js cells (#510)
9b2f217 
* add require in storybook to test "magic" cells and Create NotebookWithD3.stories.js
* Create ArticleCellIframeOutputs.js
* Switch component used for ArticleCell outputs when isMagic is true, then forward isMagic to ArticleCellOutput to use the Iframe component with magic features
* fix #511 output image data contained newlines....
* fix #509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/issue 509 magic js cells C2DH/journal-of-digital-history
2 participants
@danieleguido @eliselavy