Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are volumes.txt correct? #4

Open
treanus opened this issue Nov 5, 2021 · 6 comments
Open

Are volumes.txt correct? #4

treanus opened this issue Nov 5, 2021 · 6 comments
Assignees

Comments

@treanus
Copy link

treanus commented Nov 5, 2021

Thx for making available hd-glio-auto!

I observed a possible problem with the reported values in volumes.txt.

Seems like the reported volume in mm3, equals the number of voxels in the segmentation, but not the actual volume in mm3!
If voxel sizes are isotropic 1x1x1 mm these are correct.
However, when using a different resolution the output seems to be wrong.

An fslstats -V of the different segmentations shows this.

@jenspetersen
Copy link
Collaborator

Hi! You're actually correct, we're just counting voxels, probably because I copied that part from somewhere else where we actually resampled to 1mm isotropic. This doesn't happen here, so it's a pretty embarrassing oversight, thanks for raising the issue! There will be a new release soon, with that part fixed of course :)

@jenspetersen jenspetersen self-assigned this Dec 6, 2021
@giemmecci
Copy link

Hi, thanks for sharing HD-GLIO!

I wondered if this has been fixed since I have the same issue described by @treanus.

Thanks!

@jenspetersen
Copy link
Collaborator

Hey @giemmecci @treanus, sorry for the delay. There is a new version that you can currently get with docker pull jenspetersen/hd-glio-auto:test. I will also move it to the default tag soon, but if you have time to test that would be great!

@giemmecci
Copy link

Thanks so much, and no problem at all!

I will test it starting in June and will let you know. Thanks!

@giemmecci
Copy link

Hi,
The issue seems to be gone with the new version: in the attached figure, the output of the previous version is on the left, and the one of the latest version is on the right; as you can see, in the new version, the total volumes are in line with ITK-snap.

I have tested it only on one case, but I will keep using the new version and monitor the output.

Thanks!
Screenshot from 2022-08-10 11-55-16

@giemmecci
Copy link

Hey @giemmecci @treanus, sorry for the delay. There is a new version that you can currently get with docker pull jenspetersen/hd-glio-auto:test. I will also move it to the default tag soon, but if you have time to test that would be great!

Hi @jenspetersen,
Has the test version been moved to the default one?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants