-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set ingestion timer trigger to never run in staging #198
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
@@ -30,5 +30,5 @@ module "template" { | |||
|
|||
environment = "stg" | |||
deployer_id = "f5feabe7-5d37-40ba-94f2-e5c0760b4561" //github app registration in CDC Azure Entra | |||
cron = "0 30 9 * * 1-5" // Every weekday at 9:30 AM | |||
cron = "* * * 30 Feb *" //run every second of February 30th, which never happens and is the equivalent of never running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a more explicit method to disable the cron job, such as setting the cron expression to an empty string or using a conditional expression based on the environment. This will make the intent clearer and avoid potential confusion with the use of a non-existent date. [important]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An empty CRON expression is not valid here
PR Code Suggestions ✨Explore these optional code suggestions:
|
Quality Gate passedIssues Measures |
Description
Until the mu character ingestion issues are fixed, turn off auto ingestion in staging so that files won't have to be re-uploaded
Issue
CDCgov/trusted-intermediary#1467