Skip to content
This repository has been archived by the owner on Feb 7, 2025. It is now read-only.

Setup Azure Alerts for 5XX Errors #202

Closed
wants to merge 11 commits into from
Closed

Setup Azure Alerts for 5XX Errors #202

wants to merge 11 commits into from

Conversation

pluckyswan
Copy link
Contributor

Description

Stuff

Issue

CDCgov/trusted-intermediary#1394

Checklist

Note: You may remove items that are not applicable

pluckyswan and others added 10 commits October 22, 2024 11:49
@pluckyswan
initial slack setup in terraform
3f91107
@saquino0827 @somesylvie
@pluckyswan @jherrflexion @halprin
Add alert rule, group, and action for monitoring purposes
c3c1809 
Co-authored-by: Sylvie <[email protected]>
Co-authored-by: pluckyswan <[email protected]>
Co-authored-by: James Herr <[email protected]>
Co-authored-by: halprin <[email protected]>
@saquino0827 @somesylvie
Add 4xx test api
e09bb82 
Co-authored-by: Sylvie <[email protected]>
@saquino0827 @somesylvie
Fix linting for terraform
daba388 
Co-authored-by: Sylvie <[email protected]>
@saquino0827 @somesylvie @halprin
Fix regex for non-pr env check and fix alert sleck email secret
7d258d8 
Co-authored-by: Sylvie <[email protected]>
Co-authored-by: halprin <[email protected]>
@saquino0827 @somesylvie @halprin
Fix terraform apply parameters to be a secret
d0b2977 
Co-authored-by: Sylvie <[email protected]>
Co-authored-by: halprin <[email protected]>
@saquino0827
Merge branch 'main' into 4xx-alerts
3f16ac8
@pluckyswan
Merge branch '4xx-alerts' into new-5xx-alertzz
47daf55
@pluckyswan
Merge branch '4xx-alerts' into new-5xx-alertzz
7426f7f
@pluckyswan
added 5xx resource in terraform
85753a4
@github-actions GitHub Actions
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Misleading Endpoint
The endpoint '/test400' seems to be a test endpoint for generating 400 errors. This could be misleading as it does not reflect a real health check scenario.

Hardcoded Values
The hardcoded values for thresholds and frequencies in alert definitions might not be suitable for all environments or use cases.

github-actions[bot]
github-actions bot reviewed Oct 23, 2024
View reviewed changes
src/cmd/main.go
@@ -77,6 +77,16 @@ func setupLogging() {
func setupHealthCheck() {
slog.Info("Bootstrapping health check")

http.HandleFunc("/test400", func(response http.ResponseWriter, request *http.Request) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider renaming the endpoint from '/test400' to something more indicative of its purpose, like '/generate-400-error'. This will make the codebase more readable and maintainable. [important]

@github-actions GitHub Actions
Copy link

PR Code Suggestions ✨

No code suggestions found for the PR.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pluckyswan pluckyswan closed this Oct 24, 2024
@pluckyswan pluckyswan deleted the new-5xx-alertzz branch October 24, 2024 18:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pluckyswan @saquino0827