Double locking in Intermediary

[jcrichlake]

DevEx/OpEx

Priority: High

Inside of TransformationRuleEngine.java and ValidationRuleEngine we are checking rules.isEmpty() twice, once before the synchronized keyword and again afterward. We need to remove the check before the synchronized keyword to satisfy the scan and not provide a false sense of security.

Tasks

Additional Context

Add any other context or screenshots about the work here.

[halprin]

This might be able to be fixed with simply adding volatile keyword to the rules fields.

[JohnNKing]

PR is under review.

[JohnNKing]

PR: #1228