Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding AI to our PR review process #1357

Closed
15 tasks done
saquino0827 opened this issue Sep 24, 2024 · 5 comments
Closed
15 tasks done

Adding AI to our PR review process #1357

saquino0827 opened this issue Sep 24, 2024 · 5 comments
Labels
devex/opex A development excellence or operational excellence backlog item. Stream 1

Comments

@saquino0827
Copy link
Contributor

saquino0827 commented Sep 24, 2024

DevEx/OpEx

  • Using software similar to AWS CodeGuru or a Github Action script with 3rd party libraries prompting Azure OpenAI or whatever LLM, we can us AI to review and leave comments as a Senior Developer.

Tasks

  • Look into options available for AI PR reviews. (We decided on PR-Agent
  • Implement an option of your choice
    • Add GitHub action
    • Add secrets
  • Fix Github Manual PR Agent Triggers on PR Comments
    • Remove Auto-Labelling from the PR Agent (The settings don't seem to turn this off but we're okay with that)
    • Check out the PR Agent settings and see what we may need/want to give a try. See docs here and also the configuration file
    • Remove this trigger: pull_request_review_comment
    • Set up a time in engineering block to review this, sometime next week. Maybe next Friday (10/18)
  • Test PR Agent with example PR in TI and SFTP Ingestion Service
  • Create new Cards for the following:
    • Migration of Azure LLM hosting to the new Flexion Repository here
    • SFTP Ingestion Service Setup with PR Agent.
      • Add this task to this Card: Example PR for SFTP Ingestion Service (should include bad code changes, etc.)

Additional Context

Add any other context or screenshots about the work here.

@saquino0827 saquino0827 added devex/opex A development excellence or operational excellence backlog item. Stream 1 labels Sep 24, 2024
@saquino0827
Copy link
Contributor Author

PR-Agent could be a good choice for this: https://qodo-merge-docs.qodo.ai/

@saquino0827
Copy link
Contributor Author

We were able successfully get the PR-Agent to review our PR.
We will present this at engineering block tomorrow to get feedback.
Two suggestions from @halprin were:

  1. Instead of Terraforming Azure OpenAI in our TI Repo, get a new flexion repo created that can have the terraform for Azure OpenAI and all it's required Azure Resources. Then, have the PR-Agent in the TI Repository call the Flexion Azure OpenAI instead.
  2. Configuration changes to remove auto labelling.

@saquino0827
Copy link
Contributor Author

  1. Review all the settings for PR Agent. For example, the PR Agent is set to Auto-Describe where the Agent adds it's own description. We discussed that we may not want this to be built automatically because we want our engineers to provide their own description. We want to encourage our engineers to think for themselves rather than rely on AI.
  2. We're planning on moving the LLM specific hosting to a flexion wide repo, instead of only within the TI Azure Account.

This was referenced Oct 15, 2024
@saquino0827
Copy link
Contributor Author

Created Issue #1431 from the set of tasks.

@saquino0827
Copy link
Contributor Author

New Issue created here #1433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devex/opex A development excellence or operational excellence backlog item. Stream 1
Projects
None yet
Development

No branches or pull requests

2 participants