Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename reportId variables #1601

Merged
merged 20 commits into from
Dec 11, 2024
Merged

Rename reportId variables #1601

merged 20 commits into from
Dec 11, 2024

Conversation

pluckyswan
Copy link
Contributor

@pluckyswan pluckyswan commented Nov 20, 2024 •
edited
Loading

Description

Rename variables, like (sent/received)SubmissionId and (sent/received)MessageId to be (inbound/outbound)ReportId, and any related functions. The naming, inbound and outbound, is from the perspective of TI. The id that we were receiving from ReportStream is now the inbound id while the id we were sending to ReportStream is now the outbound id.

Issue

#1404

Checklist

Note: You may remove items that are not applicable

@github-actions GitHub Actions
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Consistency Check
Ensure that the renaming of variables from 'receivedSubmissionId' to 'inboundReportId' maintains consistency across all related methods and classes, especially where method signatures and return types might be affected.

@github-actions GitHub Actions
Copy link

PR Code Suggestions ✨

No code suggestions found for the PR.

basiliskus
basiliskus reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@basiliskus basiliskus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed a few of the changes and added a couple of comments. I'll continue reviewing later

etor/src/main/java/gov/hhs/cdc/trustedintermediary/etor/messages/SendMessageHelper.java Outdated Show resolved Hide resolved
etor/src/main/java/gov/hhs/cdc/trustedintermediary/etor/messages/SendMessageHelper.java Outdated Show resolved Hide resolved
basiliskus
basiliskus reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@basiliskus basiliskus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment. Otherwise looking great!

etor/src/main/java/gov/hhs/cdc/trustedintermediary/etor/results/SendResultUseCase.java Outdated Show resolved Hide resolved
@pluckyswan
Copy link
Contributor Author

Left one comment. Otherwise looking great!

Did we want to change recordId to reportId? Or is that a different card?

@basiliskus
Copy link
Contributor

Did we want to change recordId to reportId? Or is that a different card?

That would be a different card. It involves changes in RS, so we need to coordinate to make those changes in TI and RS at the same time

halprin
halprin reviewed Nov 21, 2024
View reviewed changes
Copy link
Member

@halprin halprin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is great work. If you're going keep the modifications in DatabasePartnerMetadataStorage.java, then you'll need to also add a database migration in this PR, so that everything works when this PR is merged.

etor/src/main/java/gov/hhs/cdc/trustedintermediary/etor/messages/SendMessageHelper.java Outdated Show resolved Hide resolved
basiliskus
basiliskus reviewed Dec 6, 2024
View reviewed changes
Copy link
Contributor

@basiliskus basiliskus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @pluckyswan! I just left one comment but otherwise looks great

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 6, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
96.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pluckyswan pluckyswan marked this pull request as ready for review December 6, 2024 20:34
halprin
halprin approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@halprin halprin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve. I would get at least one other approval, though.

tjohnson7021
tjohnson7021 approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@tjohnson7021 tjohnson7021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This great and very helpful!

@pluckyswan pluckyswan merged commit c83806a into main Dec 11, 2024
17 checks passed
@pluckyswan pluckyswan deleted the rename-variables branch December 11, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@somesylvie somesylvie somesylvie left review comments

@tjohnson7021 tjohnson7021 tjohnson7021 approved these changes

@halprin halprin halprin approved these changes

@basiliskus basiliskus basiliskus approved these changes

@saquino0827 saquino0827 Awaiting requested review from saquino0827

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pluckyswan @basiliskus @halprin @somesylvie @tjohnson7021