-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS9 - left utility buttons, visible on first load #353
Comments
Yes, same issue here, but on iPad (mini 2) only, not on iPhone. Not tested on other devices than those. Any solutions yet? |
I have this issue when changing app width on iPadAir2 multi task split. |
Same problem here on iPhone. |
So, I'm not quite sure why, but it appears that there is a strange conflict/race condition when SWTableViewCell calls layoutSubviews. If you set a break in contentOffsetForCellState, you'll see that layout for each cell is called twice. When its called directly via the layoutSubviews method, it sets the X offset correctly, but when called via the [super layoutSubviews] method, the cellState oddly ends up being kCellStateLeft. Workaround: If you move the [self updateCellState] inside the following If block: if (!self.cellScrollView.isTracking && !self.cellScrollView.isDecelerating) It seems to work as expected. Hope that helps everyone. |
I'm seeing the same issue on ios9 iPads only. @foreignmedia I tried your workaround but without success - in case I misunderstood, you are suggesting we modify the layoutSubview in SWTableViewCell.m to this?
Thank you. |
@hhp21 That's what I had but it seems like that wasn't a good work-around as the issue came back for me as well. I haven't been able to trace it back to the issue, but I'm still seeing my cells being laid out twice. Once with the correct cellState (Center) and one with the incorrect one (Left). |
same here |
Fix #353 does actually not seem to fix this. At least not for me... :/ |
I observed this issue on iPad Mini (2) with iOS 9.0 installed. Now, with iOS 9.0.2 installed, it no longer occurs on my iPad. However, in Simulator with iOS 9.0, the issue is still there if it simulates iPad. |
For me, the problem went away after upgrading to iOS 9.1 ... |
For me the problem still remains after update IOS 9.1 and Fix #355 |
Somehow the content offset is reset to zero during the super.layoutSubviews() call, that would cause SWTableViewCell.updateCellState() to set the cell state to Left when the cell is initially displayed.
|
It worked for me! Thanks! |
This is happening to me on all devices on iOS 9.1. @qi-wang fix seems to solve it for me by just leaving out the iPad check. |
qi-wang code fixed the problem in my real device iPad Air. Thanks! |
Yeah, it worked~~~ |
worked, thanks |
As described in this issue CEWendel#353, on the first load of the view, cells show the left utility buttons. This solve the problem
Hi, i've done a pull request based on this issue https://github.com/CEWendel/SWTableViewCell/pull/378. Hope it could be useful. |
I think this is again happening on iOS 10.0.1 and 10.1.1 on iPad Pro only |
I have the same problem on Ipad IOS 9.5.3 or heigher |
Instead of this: I have used following and it started working:
|
Hi,
the lib worked perfectly for me on iOS7, iOS8, but now when building on iOS9, all of the left utility buttons are by default swiped in. User can swipe them out but still it's strange. Wondering what has changed on iOS9 to cause this.
Anybody with the same issue?
The text was updated successfully, but these errors were encountered: