Cmap add test gdamiand #8737
Open
Cmap add test gdamiand #8737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
master or release branch? |
|
Maybe it is better for release branch? (but the bug is very specific thus it is ok to use master) |
Comment on lines
+89
to
+90
| if(this->cont()) | ||
| { mark_cell<Map,i,dim>(amap, adart, mcell_mark_number); } |
There was a problem hiding this comment.
Wouldn't it be better to have the test inside the function (as this is anyway provided) and this will in one go protect all calls to the function.
There was a problem hiding this comment.
the mark_cell function takes a descriptor as input; and has a requirement that this descriptor is "valid".
thus I think the current use is correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Solve a bug for CMap and GMap when we iterate on an empty map with an iterator that needs to mark cells, and when using index version.
Release Management