Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Connection Dialog and Change All Components Dialog #290

Merged
merged 55 commits into from
Jun 21, 2021
Merged

Updated Connection Dialog and Change All Components Dialog #290

merged 55 commits into from
Jun 21, 2021

Conversation

vyiu
Copy link

@vyiu vyiu commented Jun 20, 2021

Updated Connection Dialog (issue #229) and Change All Components Dialog (issue #259)

rkrishnasanka and others added 30 commits January 16, 2021 09:20
…re are 2 pieces still left:

1. Need to remove a circular reference
2. Need remove the Registry.js
… class Device from Class Feature

Started remvoving all the `require`s from the codebase. Right now there are 2 pieces still left:
1. Need to remove a circular reference with colors import in viewmanager

Removed the Registry requirements
… class Device from Class Feature

Started remvoving all the `require`s from the codebase. Right now there are 2 pieces still left:
1. Need to remove a circular reference with colors import in viewmanager

Removed the Registry requirements
Somewhat simplifies the build process while adding hot relaoding
dev server, easier intergration into eslint and babel at compile
time and better warnings for issues like mixed case imports.
Added `style-loader` and `css-loader` to `webpack-config.js` to allow
importing of css in code

Added support for class properties for babel transpiling

Renabled external resources in index.html

Imported material css in appSetup, the dev webserver setup makes
it hard to include, local assets during development. May want to be
revised when it comes to production builds

Refactored Examples to export an object due to issues with no default
exports ( in the Vue experiment repo)
… here will work for us to just drop the dialog in order
hiniko and others added 23 commits January 27, 2021 20:05
Fixes some slight graphical oddness on the buttons
Renamed to conform with Pascal Case naming of other files
This is a bit of a beefy one. Here is a breakdown:

* Created a property drawer component for the many elements that can be configured. Some issues still need a look
** when the popup window is created it need to take into account the page bottom and offset it self so it remains on screen. Failing to do with leades to a white gap scrollable area appearing
** there needs to be a global event to close the active drawers when another is clicked
** in dev serve mode, a page reload leaves a property window open and orphaned. May need a page reload detection
** Each drawer has a specs file noting the control type and values it should use. There is likely a much, better and compositional way of doing this, However on the live app values of min, max and shared are not really consistent. I've gone for the easy if not tedius route here
** Some drawers still need their specs.

* Added Events Emitter to handle cross component events
** This isn't obvious, but the vue Event system does not work cross comoonent. You can fudge it with an "Vue Event Bus" Pattern, However I have gone with EventEmitter 3 here.
** To make life simple I made the Events a Singleton using Typescript. It doesn't have much of an effect other than changing the main.js to main.ts
** In future Events Emitter should be used to pump UI events to the 3DUF core to allow updating the canvas when needed
Updated more settings to prevent stupid tabbing
@rkrishnasanka rkrishnasanka linked an issue Jun 21, 2021 that may be closed by this pull request
4 tasks
@rkrishnasanka rkrishnasanka added this to the Vue-Port milestone Jun 21, 2021
@rkrishnasanka
Copy link
Collaborator

@vyiu can you fetch upstream and then update the PR, this pull request will otherwise become really hard to do

@rkrishnasanka rkrishnasanka merged commit fe092aa into CIDARLAB:webpack-build Jun 21, 2021
@rkrishnasanka
Copy link
Collaborator

@vyiu don't worry about the fetch upstream thing, I've taken care of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Story] Create Connection Dialog in Vue.js Framework
3 participants