Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] - Issue generating mirror constraints #18

Open
rkrishnasanka opened this issue Feb 8, 2022 · 0 comments
Open

[Bug] - Issue generating mirror constraints #18

rkrishnasanka opened this issue Feb 8, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@rkrishnasanka
Copy link
Contributor

Update the algorithm in mirrorconstraint.py to quickly traverse the children of the root node and identify the mirror components.

The current algorithm takes far too long to generate the constraints. This is blocking the constraint JSON generation.

Suggestions:

  1. Incorporate memoization, when evaluating the group for the components (the current implementation doe not do that)
  2. Ensure that the component only exists in 1 mirror group by making sure that the shortest path to the root component all exist in the same mirror group
@rkrishnasanka rkrishnasanka added the bug Something isn't working label Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant