Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pylint: Module causal_testing.testing.estimators #160

Open
jmafoster1 opened this issue Mar 9, 2023 · 0 comments
Open

Pylint: Module causal_testing.testing.estimators #160

jmafoster1 opened this issue Mar 9, 2023 · 0 comments
Labels
enhancement New feature or request Testing

Comments

@jmafoster1
Copy link
Contributor

causal_testing/testing/estimators.py:20:0: R0902: Too many instance attributes (8/7) (too-many-instance-attributes)
Currently, we have

        self.treatment = treatment # Rename to treatment_variable?
        self.treatment_value = treatment_value # The treatment value of the treatment variable
        self.control_value = control_value # The control value
        self.adjustment_set = adjustment_set # The set of variables we need to adjust for
        self.outcome = outcome # The outcome variable
        self.df = df # The data
        self.effect_modifiers = {} # The effect modifier configuration
        self.modelling_assumptions = [] # The modelling assumptions

Could possibly get away with passing the base test case here, although we don't need the effect attribute. Otherwise, I think we really do need everything here.

causal_testing/testing/estimators.py:37:4: R0913: Too many arguments (8/5) (too-many-arguments)
This would be solved by refactoring the above.

causal_testing/testing/estimators.py:94:4: R0913: Too many arguments (9/5) (too-many-arguments)
Instance of the abstract Estimator class.

causal_testing/testing/estimators.py:293:4: R0913: Too many arguments (10/5) (too-many-arguments)
Another instance of the abstract Estimator class.

@f-allian f-allian added the enhancement New feature or request label Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Testing
Projects
None yet
Development

No branches or pull requests

2 participants