Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identification is very slow for big DAGs #259

Open
jmafoster1 opened this issue Feb 2, 2024 · 2 comments
Open

Identification is very slow for big DAGs #259

jmafoster1 opened this issue Feb 2, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@jmafoster1
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Identification for large DAGs is very slow.

Describe the solution you'd like
Is there anything else we can parallelise to speed things up a bit? Or maybe we can get a progress bar or something so we can see how it's doing?
mwe.zip
(See example DAG, data, and test script for demo, it's been about 5 mins now and it's still not finished.)

@jmafoster1
Copy link
Contributor Author

As an update, it was still going after 2 days! I will try and look into it

@jmafoster1
Copy link
Contributor Author

Update: The problem is with this method, which seems to have a very deep recursive structure
https://github.com/CITCOM-project/CausalTestingFramework/blob/9abdcbc0710297ec04a8dfd3e70bd0d78f407653/causal_testing/specification/causal_dag.py#L23C5-L23C21

@f-allian f-allian added the enhancement New feature or request label Jul 23, 2024
@f-allian f-allian self-assigned this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants