-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BB2-1728: Proof of concept for C4DIC implementation #1267
Draft
jimmyfagan
wants to merge
13
commits into
master
Choose a base branch
from
feature/c4dic
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+800
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* BB2-Added new scopes for permissions to ic endpoints * Add insurance card urls * Initial commit for C4DIC * Fix formatting errors * Tweaks to fix unit tests. --------- Co-authored-by: Adrian Jones <[email protected]>
* Catch initial misses * Replace sample output with samples from BFD, remove Org endpoint, adjust logic for Patient endpoint * Add old sample files back in * Remove unrelated change
#1241) * back end changes: enrich c4dic coverage w supporting image * fix linting * fix deps * fix linting * fix typos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BB2-1728
What Does This PR Do?
This PR does three main things, two of which are temporary for the Proof of Concept, and only one of which would be necessary in a permanent implementation. The two temporary changes:
The change that would be needed permanently is related to the handling of the
_profile
parameter, since that will be required for API users to specify if they want Coverage resources corresponding to C4BB or C4DIC.Corresponding changes to the Python sample client can be found in this draft PR.
What Should Reviewers Watch For?
If you're reviewing this PR, please check that the changes can be understood easily enough even without recent knowledge of the conversations around C4DIC.
Validation
This was continually validated through POC demos in the last few months of 2024.
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
security engineer's approval.
Any Migrations?
etc)