Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BB2-1728: Proof of concept for C4DIC implementation #1267

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

jimmyfagan
Copy link
Contributor

@jimmyfagan jimmyfagan commented Nov 13, 2024

JIRA Ticket:
BB2-1728

What Does This PR Do?

This PR does three main things, two of which are temporary for the Proof of Concept, and only one of which would be necessary in a permanent implementation. The two temporary changes:

  • Add support for returning hardcoded C4DIC resources. These are kept in a separate folder as json files that can be returned by a helper function. To enable this, in each desired function (read Patient, search Patient, read Coverage, search Coverage) there is a variable that can be set to enable the returning of those hardcoded resources.
  • Point to the test instance of BFD where as of today the C4DIC profile is currently supported. This largely eliminates the need for the hardcoded C4DIC resources, but if the BFD team removes the C4DIC profile from their test instance, the hardcoded resources can be used as a fallback.

The change that would be needed permanently is related to the handling of the _profile parameter, since that will be required for API users to specify if they want Coverage resources corresponding to C4BB or C4DIC.

Corresponding changes to the Python sample client can be found in this draft PR.

What Should Reviewers Watch For?

If you're reviewing this PR, please check that the changes can be understood easily enough even without recent knowledge of the conversations around C4DIC.

Validation

This was continually validated through POC demos in the last few months of 2024.

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies
  • Modifies any security controls
  • Adds new transmission or storage of data
  • Any other changes that could possibly affect security?
  • Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team
    security engineer's approval.

Any Migrations?

  • Yes, there are migrations
    • The migrations should be run PRIOR to the code being deployed
    • The migrations should be run AFTER the code is deployed
    • There is a more complicated migration plan (downtime,
      etc)
  • No migrations

jimmyfagan and others added 9 commits June 13, 2024 13:03
* BB2-Added new scopes for permissions to ic endpoints

* Add insurance card urls

* Initial commit for C4DIC

* Fix formatting errors

* Tweaks to fix unit tests.

---------

Co-authored-by: Adrian Jones <[email protected]>
* Catch initial misses

* Replace sample output with samples from BFD, remove Org endpoint, adjust logic for Patient endpoint

* Add old sample files back in

* Remove unrelated change
#1241)

* back end changes: enrich c4dic coverage w supporting image

* fix linting

* fix deps

* fix linting

* fix typos
@jimmyfagan jimmyfagan changed the title Feature/c4dic BB2-1728: Proof of concept for C4DIC implementation Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants