Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OI_eval breaks for 1D data due to qhull requirements #11

Open
hunterbarber opened this issue Mar 27, 2024 · 1 comment
Open

OI_eval breaks for 1D data due to qhull requirements #11

hunterbarber opened this issue Mar 27, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@hunterbarber
Copy link
Collaborator

When space is 1D, OI_eval breaks due to

  File "...\shower_operability.py", line 24, in main
    OI = opy.OI_eval(TDS_region, EDS_bounds, perspective='inputs')
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "...\opyrability.py", line 423, in OI_eval 
    volumes_i.append(sp.spatial.ConvexHull(v_intersect).volume)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "_qhull.pyx", line 2431, in scipy.spatial._qhull.ConvexHull.__init__
  File "_qhull.pyx", line 279, in scipy.spatial._qhull._Qhull.__init__
ValueError: Need at least 2-D data

@hunterbarber hunterbarber added the bug Something isn't working label Mar 27, 2024
@hunterbarber
Copy link
Collaborator Author

hunterbarber commented Apr 8, 2024

Can be bypassed (or forced) by hypervol_calc='polytope' in OI_eval if sufficient for 1D problems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant