-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally support C-grid connectivity in deseas #37
Comments
@aekiss Yes, my understanding is that it does assume B-grid connectivity. I don't remember anymore all the details of the algorithm, but I think this is the relevant piece of code: domain-tools/src/topography.f90 Lines 323 to 331 in ab469df
|
ok, ta, as suspected then. |
@micaeljtoliveira it looks to me like we could optionally support C-grid connectivity rules by simply omitting the domain-tools/src/topography.f90 Lines 328 to 329 in ab469df
|
@aekiss Yes, that sounds right. |
Just for reference, mom6-regional has this code for removing narrow channels https://github.com/COSIMA/regional-mom6/blob/0bfe4ba7aab3f27821476b83130861d6922a6c80/regional_mom6/regional_mom6.py#L1311 |
@micaeljtoliveira, @angus-g do you know whether domain-tools/src/topography.f90 Line 495 in ab469df
|
As long as it's wet on all those sides, I don't think there's an issue, no. |
Hi @micaeljtoliveira, does
deseas
assume B-grid connectivity requirements? I guess this is controlled by the choke criteria intopography_number_seas
? https://github.com/COSIMA/domain-tools/blob/master/src/topography.f90#L225i.e. will we need to change this to allow marginal seas to be regarded as connected to the ocean when the outlet is 1 cell wide on a C-grid (e.g. Gibraltar)?
The text was updated successfully, but these errors were encountered: