Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task: review IoTDB integration into WAII upstream and discuss possible merge #19

Closed
2 tasks done
slawr opened this issue Feb 14, 2024 · 3 comments
Closed
2 tasks done
Assignees
Labels
task Task not fitting other labels, e.g. project ops

Comments

@slawr
Copy link
Collaborator

slawr commented Feb 14, 2024

Some details of integrating a new State Storage backend into the WAII Service Manager are perhaps not documented.

Task outline:

  • We should review the integration with upstream maintainers.
  • Also discuss whether the new backends can be merged upstream.

Some possible areas for review:

  1. Does setVehicleData() implementation meet WAII input/output requirements? e.g. is TS returned in correct format?
  2. Does getVehicleData() implementation meet WAII input/output requirements? e.g. is TS returned in correct format?
  3. Does ServiceMgrInit() implementation meet WAII requirements?
  4. Does WAII have a debug logging mechanism that should be supported?
@slawr slawr added the task Task not fitting other labels, e.g. project ops label Feb 14, 2024
@slawr slawr added this to the Add new DB backends to WAII milestone Feb 14, 2024
@slawr slawr moved this from Next to In Progress in Central Data Service Playground Feb 15, 2024
@slawr slawr self-assigned this Feb 15, 2024
@slawr
Copy link
Collaborator Author

slawr commented Feb 15, 2024

Pull request created in upstream project w3c/automotive-viss2#110 and discussion started with maintainers.

@slawr
Copy link
Collaborator Author

slawr commented Mar 15, 2024

Upstream WAII project has merged the following PR's covering IoTDB:
Documentation: COVESA/vissr#2
Runtime config: COVESA/vissr#5
Add get/set support: w3c/automotive-viss2#110

I believe that covers all the basic bases for adding IoTDB support to WAII.
@UlfBj anything you think is missing before I close this?

@slawr
Copy link
Collaborator Author

slawr commented Apr 26, 2024

The code has been merged upstream and no further review feedback from the upstream maintainers so closing this as done. With handle any follow up with new tasks

@slawr slawr closed this as completed Apr 26, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Central Data Service Playground Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Task not fitting other labels, e.g. project ops
Projects
Development

No branches or pull requests

2 participants