Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build ASTree driven by a data structure instead #3

Closed
gunnarx opened this issue May 17, 2021 · 1 comment
Closed

Build ASTree driven by a data structure instead #3

gunnarx opened this issue May 17, 2021 · 1 comment
Labels
discussion Things that need some thinking, and feedback from several to find consensus first. enhancement New feature or request

Comments

@gunnarx
Copy link
Collaborator

gunnarx commented May 17, 2021

  • Consider if there's a way to build the AST from a configuration data structure (reflecting the schema). As of now it is done very 'directly' in concrete code that references specific functions for each data type, etc. An alternative programming style is to write a "generic" algorithm that is instead driven by an input data structure.

This is an idea, and might look more "elegant" than the very direct approach in current parser.py. On the other hand, the direct approach ought to be easily readable and understandable. Simplicity might not be bad from that perspective. This is mostly something to think about, and not critical because the current code "just works".

@gunnarx gunnarx added the enhancement New feature or request label May 17, 2021
@gunnarx gunnarx changed the title AST build-up code driven by data structure instead Build ASTree driven by a data structure instead May 17, 2021
@gunnarx gunnarx added the discussion Things that need some thinking, and feedback from several to find consensus first. label May 18, 2021
@gunnarx
Copy link
Collaborator Author

gunnarx commented May 18, 2022

Proposed in #26

@gunnarx gunnarx closed this as completed May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Things that need some thinking, and feedback from several to find consensus first. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant