Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lack of voices (polyphony) leads to errors / undefined behavior in some metrics #2

Open
lmartak opened this issue Feb 13, 2025 · 1 comment
Assignees

Comments

@lmartak
Copy link
Collaborator

lmartak commented Feb 13, 2025

When a midi file doesn't contain enough voices / polyphony, it leads to errors in articulation and dynamics metrics.

Introduction of an "empty voice" addresses the issue for articulation metrics, but the same trick doesn't amount to a complete solution for the dynamics metrics.

Perhaps a different workaround / definition of the dynamics metric is needed for such special case (lack of voices in one of the midi files).

This notebook to reproduces the issue using a monophonic midi file.

@huispaty huispaty self-assigned this Feb 21, 2025
@huispaty
Copy link
Collaborator

Hi Lukas! Thanks for reporting the bug! I’ve added a fix in the same branch where you posted the issue—could you check if it works for your case? I tested it with the provided test file, but let me know if you run into any issues. If all looks good, I’ll add an official test and create a PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants