Kern fixes (parsing editorials) #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fosfrancesco
requested changes
Oct 2, 2024
removing unused comments.
fosfrancesco
approved these changes
Oct 2, 2024
Merged
manoskary
added a commit
that referenced
this pull request
Feb 27, 2025
PR for Version 1.6.0. The following changes were applied: # Updated Merge Report below the updated notes for this PR to include most recent changes ## PR for version 1.6.0 This new version addresses multiple changes, bug fixes and new features: ### New features - Measure refactor for musicxml, match, midi, note array to part in #376 - Measure feature #377 - Clef feature #382 - Clef map #384 #396 - Stem direction #392 - Support for cross staff voices in mei #397 - Improved parsing of Kern scores #413 - Fixed import for performance pedal #399 - Tick Units are now supported for pianoroll creation #412 - Scores can be loaded directly for URL #404 - Support for invisible objects in musicxml import #401 - Support for Fingering annotations in MusicXML and MEI import/export #403 ### Bug fixes - Corrected `get_time_maps_from_alignment` #360 - Corrected metrical strength features #364 - Corrected offsets for tied notes #366 - Fixed import issue #368 - Fixed Kern parsing #370 - Duration of Chord Notes #418 - Corrected symbolic note duration #372 - Fixed tuplet bug #387 - Addressed sorting for enharmonic notes #407 - Fixes eq bug on performed notes #422 - Fixed timing-tempo change bug #427 ### Other Changes - Added check for empty note array #361 - Improved documentation #362 #364 - Removed default voice estimation #373 - Added warning #379 - Removed ordering in musicxml export #391 - Improved Fingering parsing in MusicXML that could result to errors #416 - Replaced Deprecated Scipy Function #417 - Improved support for input and export in musicxml tuplet object - New option to force add new segments #410
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for parsing Kern Files with Editorial Comments and Alternative Passages.
This PR addresses the parsing of Kern scores that include editorial comments such as alternative passages.
Such passages that could previously cause parsing errors can now be ignored and only the original passage or part is kept.
Specific Comments on Code
load_kernwhich were inverting the part order, this has to be avoided in case the far right part contains only editorials. Instead, the part order is inversed when the partlist is passed to the score. Since this functionality changes, it should be monitored for potential errors.