Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dagger should not depend on Circuit #2

Closed
NathanCQC opened this issue Apr 28, 2023 · 3 comments
Closed

Dagger should not depend on Circuit #2

NathanCQC opened this issue Apr 28, 2023 · 3 comments

Comments

@NathanCQC
Copy link
Collaborator

NathanCQC commented Apr 28, 2023 •
edited
Loading

Dagger not depend on the self._circuit It should only depend on the _cuquantum_interleaved() method.

This is because once the circuit is post selected by adding caps to the post select qubits. When this network is daggered. It does not know about the caps and returns an un post selected network.
@NathanCQC
Copy link
Collaborator Author

I guess this will be fixed when we migrate to the Network class.

@yapolyak
Copy link
Contributor

yapolyak commented May 6, 2023

I think cuQuantum actually has this functionality now, so we could totally look into adding it. Or we can discuss how to fix this ourselves!

@PabloAndresCQ
Copy link
Collaborator

Closing this issue because it refers to the old (soon to be deprecated API). The new API GeneralState will be full-featured (*) once #165 is merged.

(*) Postselection is not currently supported. It is not hard to include, though.

@PabloAndresCQ PabloAndresCQ closed this as not planned Won't fix, can't repro, duplicate, stale Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@NathanCQC @yapolyak @PabloAndresCQ