Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate potential CMake improvements #1482

Closed
jake-arkinstall opened this issue Jul 4, 2024 · 2 comments · May be fixed by #1501
Closed

Investigate potential CMake improvements #1482

jake-arkinstall opened this issue Jul 4, 2024 · 2 comments · May be fixed by #1501
Assignees
@jake-arkinstall
Labels
stale

Comments

@jake-arkinstall
Copy link
Contributor

At the moment, dependant projects need to find and link Eigen3 in order to link tket::tket, because:

  • public-facing headers depend on eigen headers.
  • eigen is linked privately in CMakeLists.txt

Ideally, tket/test/CMakeLists.txt should build by linking only tket and catch2, and having cmake transitively include the dependencies of tket.
@jake-arkinstall jake-arkinstall self-assigned this Jul 4, 2024
@jake-arkinstall jake-arkinstall mentioned this issue Jul 25, 2024
Open
5 tasks
@jake-arkinstall jake-arkinstall linked a pull request Jul 25, 2024 that will close this issue
Cmake improvements and Nix unification with existing pytket setup #1501
Open
5 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2024

This issue has been automatically marked as stale.

@github-actions github-actions bot added the stale label Nov 2, 2024
@jcqc
Copy link

jcqc commented Nov 6, 2024

Closing as won't do.

@jcqc jcqc closed this as completed Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jake-arkinstall jake-arkinstall

Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cmake improvements and Nix unification with existing pytket setup CQCL/tket
2 participants
@jake-arkinstall @jcqc