Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mini-LISP JS Implementation - parentheses/brackets highlighting bug #463

Open
OfirMarkowitz1 opened this issue Sep 12, 2021 · 1 comment
Open

Mini-LISP JS Implementation - parentheses/brackets highlighting bug #463

OfirMarkowitz1 opened this issue Sep 12, 2021 · 1 comment
Assignees
@OfirMarkowitz1

Comments

@OfirMarkowitz1
Copy link
Collaborator

OfirMarkowitz1 commented Sep 12, 2021 •
edited
Loading

On the browser REPL, when multiple-line command is entered and there's matching parentheses/brackets where the opening paren/bracket is on a different line than the "active" line, the opening paren/bracket is not highlighted.

So far I managed to observe that this is a CSS bug, that is somehow related to the line-height parameter of certain div elements, but not yet figured out how to solve it.

There should be a way to modify the JQuery Terminal CSS file for a robust solution.

Bug preview:

Screen Shot 2021-09-12 at 15 18 51
@OfirMarkowitz1 OfirMarkowitz1 self-assigned this Sep 12, 2021
@OfirMarkowitz1
Copy link
Collaborator Author

Already spent a few hours on this one, and I didn't succeed in fixing it. I'm not familiar enough with CSS and even if I were, I'm not sure that it's a simple solution. Is this one a must?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OfirMarkowitz1 OfirMarkowitz1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@OfirMarkowitz1