Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can JSON 5 record detail show owning_cna, not assignerShortName, at the top? #1224

Open
ElectricNroff opened this issue Aug 24, 2022 · 3 comments
Assignees
Labels
cve-record-page HIGH-LOE ~1 - 2 weeks LoE needs-discussion Needs more discussion, either with TWG or internally

Comments

@ElectricNroff
Copy link

When a user visits the JSON 5 record detail display page, their goal might be to contact the responsible CNA to request that a CVE Record be updated. Similarly, they might want to associate the CVE Record information with the current name of a vendor who produces the vulnerable product.

<span class="has-text-weight-bold">Assigner: </span>
<span style="text-transform: capitalize;">{{cveFieldList.assigner}}</span>

and
const value = this.originalRecordData.cveMetadata?.assignerShortName;
if (this.hasData(value)) {
this.cveFieldList.assigner = value.replace('_', ' ');

(admittedly, this code is in progress and is almost certainly not intended for public consumption) seem to display the assignerShortName field from a PUBLISHED CVE Record. For a REJECTED CVE Record, assignerShortName is used similarly.

https://github.com/CVEProject/cve-schema/blob/fbf54b99da863b80ea1c721cf2e9f107913b7325/schema/v5.0/CVE_JSON_5.0_schema.json#L380-L382
says "assignerShortName ... The short name for the organization to which the CVE ID was originally assigned" and this would not necessarily help such a user to achieve their goal. The most common situation is that a CNA can request that the Secretariat change that CNA's short name via the PUT /org/{shortname} API. When the Secretariat completes this, none of the assignerShortName fields (of CVE Records belonging to that CNA) are changed. Instead, every assignerShortName field contains the old short name. However, the response to a GET /cve-id/{id} API call contains the new short name in the owning_cna field. In other words, as soon as a CNA is renamed, the GET /cve-id/{id} API immediately starts providing the correct short name value, but the GET /cve/{id} API continues to provide an outdated value indefinitely.

If the user sees an outdated short name on the JSON 5 record detail display page, they do not have a straightforward way to find contact information for the CNA. The https://www.cve.org/PartnerInformation/ListofPartners page is not searchable by previously used short names. This could be changed, but https://github.com/CVEProject/cve-website/blob/dev/src/assets/data/CNAsList.json currently does not store previously used short names in a JSON format. If the user were very familiar with the implementation of the CVE website, then they could go to https://github.com/CVEProject/cve-website/commits/main/src/assets/data/CNAsList.json and search for "Update" but most users would not know that.

To resolve this issue, one approach is to never include an assignerShortName value on the JSON 5 record detail display page. Instead, to build this page (for the PUBLISHED and REJECTED cases), there would be both a GET /cve/{id} API call and a GET /cve-id/{id} API call. The response for the latter would only be used to determine the owning_cna value for the Assigner field (i.e., for the name of the CNA). It is unlikely that a user would specifically need the assignerShortName value for their use case; however, if they did, they would still be able to find it in the full JSON 5 document.

@zmanion
Copy link

zmanion commented Aug 31, 2022

+1, this is a use case I regularly run into, and the current answer is to ask an upstream CNA, typically root/LR, so MITRE. Technical implementation aside, please provide the owning CNA information in an easy-to-find way/location in the cve.org CVE record display.

@zmanion
Copy link

zmanion commented Jan 12, 2023

Fundamentally owner and assigner are different, some discussion and a proposal to modify JSON can be found here: CVEProject/automation-working-group#116

@andrewpollock
Copy link

I think related to this:

I was looking for a way to map between a CVE 5 record's cveMetadata.assignerOrgId or containers.cna.providerMetadata.orgId back to a canonical entry in https://github.com/CVEProject/cve-website/blob/main/src/assets/data/CNAsList.json

@github-project-automation github-project-automation bot moved this to Needs Triage in CVE Website Backlog Aug 23, 2024
@athu-tran athu-tran moved this from Needs Triage to High Priority in CVE Website Backlog Aug 23, 2024
@jdaigneau5 jdaigneau5 added needs-discussion Needs more discussion, either with TWG or internally and removed high-priority labels Oct 16, 2024
@jdaigneau5 jdaigneau5 added the HIGH-LOE ~1 - 2 weeks LoE label Oct 23, 2024
@jdaigneau5 jdaigneau5 moved this from Needs Triage to Low Priority in CVE Website Backlog Jan 28, 2025
@rlxdev rlxdev moved this from Low Priority to High Priority in CVE Website Backlog Feb 3, 2025
@rlxdev rlxdev self-assigned this Feb 3, 2025
@rlxdev rlxdev moved this from Todo to In Progress in cve-website: Sprint 17: (02/10-02/21) Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cve-record-page HIGH-LOE ~1 - 2 weeks LoE needs-discussion Needs more discussion, either with TWG or internally
Projects
Development

No branches or pull requests

6 participants