Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test.cve.org no longer shows spaces in version ranges #2588

Closed
ElectricNroff opened this issue Feb 29, 2024 · 2 comments · Fixed by #2591, #2616 or #2617
Closed

test.cve.org no longer shows spaces in version ranges #2588

ElectricNroff opened this issue Feb 29, 2024 · 2 comments · Fixed by #2591, #2616 or #2617
Assignees
Labels
bug Something isn't working

Comments

@ElectricNroff
Copy link

This issue may currently be affecting the usability of test.cve.org by multiple CNAs. For example, this CVE Record:

{"dataType": "CVE_RECORD","dataVersion": "5.0","cveMetadata": {"cveId": "CVE-2024-20739",
"assignerOrgId": "b3476cb9-2e3d-41a6-98d0-0f47421a65b6","state": "PUBLISHED"},
"containers": {"cna": {"providerMetadata": {"orgId": "b3476cb9-2e3d-41a6-98d0-0f47421a65b6"},
"affected": [{"vendor": "v","product": "p","versions": [
{
  "version": "1234",
  "status": "affected",
  "lessThanOrEqual": "5678",
  "versionType": "custom"}]}],
"descriptions": [{"lang": "en","value": "acd def ghi"}],"references": [
{"url": "https://a.us"}]}}}

renders today with:

affected from1234through5678

whereas last week it would have rendered with:

affected from 1234 through 5678
@athu-tran athu-tran self-assigned this Feb 29, 2024
@athu-tran athu-tran added bug Something isn't working UI labels Feb 29, 2024
athu-tran added a commit that referenced this issue Mar 1, 2024
… preserve whitesapce configuration is not working
athu-tran added a commit that referenced this issue Mar 1, 2024
#2588 workaround to fix version spacing issue since Vuejs' and Vite's…
@ElectricNroff
Copy link
Author

I think this may fix the issue only for elements of the versions array where row.versionsChanges.length > 0 is true. For example, in the e1932df commit, the first two differences change {{word}} to {{word}}  but the third difference does not insert the  

In https://test.cve.org/CVERecord?id=CVE-2024-20694 the first element of the versions array looks wrong affected from3.6through3.6 but every other case looks OK, because every other case has a true value for row.versionsChanges.length > 0

@athu-tran
Copy link
Collaborator

@ElectricNroff Thanks for catching this. I'm going to fix this.

athu-tran added a commit that referenced this issue Mar 7, 2024
#2588 fix version spacing for versions that doesn't have any changes
@athu-tran athu-tran linked a pull request Mar 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment