Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FmlWriter produces incorrect output for bare ModifierChange.REMOVE #8

Open
Juuxel opened this issue May 3, 2022 · 0 comments
Open

Comments

@Juuxel
Copy link

Juuxel commented May 3, 2022

When you have AccessTransform.of(ModifierChange.REMOVE) in an access transform set and write that set using FmlWriter, the resulting AT file contains a broken line starting with -f.

This is not supported by the AT parser and lexer used by FML, which always expects an explicit access modifier as well.

I'm not sure if there's any good way to fix this, though, since it should probably be using the existing visibility of code in question, but that info isn't available here. In Architectury Loom, we just made it default to public-f, but that might also be unwanted.

Juuxel added a commit to architectury/at that referenced this issue Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant