The “Animated Only Visible Textures” setting is broken with the FramedBlocks tank

[Lolothepro]

Bug Description

The “Animated Only Visible Textures” setting is broken with the FramedBlocks tank

2025-01-04.21-01-35_compressed.mp4

Reproduction Steps

Install FramedBlocks & Sodium
Use a glass block in a Framed Tank
Fill the tank with lava

Log File

https://mclo.gs/6S8BNSs

Crash Report

[hjake123]

This issue also affects non-water textures inside of Reactive Alchemy crucibles.

bug_demo.mp4

[Lolothepro]

It can realistically only affect fluids because it's specifically related to the tank's contents and not its camo. My best guess would be that it's caused by the use of Neo's FluidSpriteCache (the name isn't great, it's less a cache and more a safeguard against certain crashes during resource reload - vanilla does effectively the same thing, except hardcoded to water and lava) to look up the fluid sprites in the BER
For context, the FluidSpriteCache captures the Map<ResourceLocation, TextureAtlasSprite> backing the block atlas in the same place where vanilla's LiquidBlockRenderer captures the hard-coded sprites during reload and then uses that map directly to get the sprites

XFact