Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is aria-label the correct attribute to use? #1

Open
jeremiak opened this issue Mar 9, 2023 · 0 comments
Open

Is aria-label the correct attribute to use? #1

jeremiak opened this issue Mar 9, 2023 · 0 comments
Labels
question Further information is requested

Comments

@jeremiak
Copy link
Collaborator

jeremiak commented Mar 9, 2023

The component currently takes the alt text from the children images and adds them to the <div> with an aria-label attribute, but should it instead be aria-description or aria-describedby?

From the MDN docs:

The aria-description attribute is similar to aria-label in that both provide a text string to associate with the element, but a label should be short and concise, while the description can be longer as it is intended to provide more context and information.

@jeremiak jeremiak added the question Further information is requested label Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant