Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSpec 3 Compatilbity #250

Closed
coding-bunny opened this issue Sep 23, 2015 · 6 comments
Closed

RSpec 3 Compatilbity #250

coding-bunny opened this issue Sep 23, 2015 · 6 comments

Comments

@coding-bunny
Copy link

Hello,

Running CanCanCan under RSpec 3 produces some deprecation warnings:

Deprecation Warnings:

`failure_message_for_should_not` is deprecated. Use `failure_message_when_negated` instead. Called from /var/lib/jenkins/.rvm/gems/ruby-2.2.2@riskmethods/gems/cancancan-1.7.1/lib/cancan/matchers.rb:19:in `block in <top (required)>'.

`failure_message_for_should` is deprecated. Use `failure_message` instead. Called from /var/lib/jenkins/.rvm/gems/ruby-2.2.2@riskmethods/gems/cancancan-1.7.1/lib/cancan/matchers.rb:15:in `block in <top (required)>'.

Would be cool to have these switched into the new methods.
was originally reported here as well : ryanb/cancan#997

@Senjai
Copy link
Member

Senjai commented Sep 23, 2015

@NekoNova Could you submit a PR?

@coding-bunny
Copy link
Author

Will make one tommorrow!

@coding-bunny
Copy link
Author

running some tests, then I will open the PR if it does what it's supposed to be doing.

@coding-bunny
Copy link
Author

#251

@abhishekbose87
Copy link
Contributor

@Senjai This issue can be closed as PR #251 has been merged.

@coding-bunny
Copy link
Author

will close it myself ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants