-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not trigger an error when non point geometries have aggregation options #910
Comments
As @elenatorro said, we're adding the default server aggregation to Builder. We'd need Windshaft not to return an error when the default aggregation is taking place. If you find any problem with this approach, one option could be to swallow the error only in the default aggregation is set. Perhaps instead of an error, you could add some information back in the map instantiation endpoint about if the layer was not aggregated and why. |
@ramiroaznar can the RT (@enekid?) take a look at this to unlock @elenatorro 🙏 ? |
Despite we can avoid returning the error and add info back in the map instantiation without much effort, we are not going to do that, it's returning an error by design and it's the right behavior. Basically, whoever wants to aggregate a layer needs to know what kind of geometry that layer has. From the point of view of Builder, we already know when a layer has points and then applies the right style for points when creating a new map. From Maybe the problem is bigger than we thought initially, enabling aggregation by default for new and existing maps raises a lot of open questions:
|
Ok. Closing this for now. |
Reopening this after this comment from @rochoa:
We basically need it to be able to enable Default Point Aggregation in Builder soon. |
Project: https://github.com/CartoDB/product/issues/30
We are discussing in this PR how to enable default point aggregation in builder/cartodb.js. There is no way to know the geometry before sending a layer to Windshaft, and as we are sending
aggregation
options, we are receiving an error when the geometries are not points.In order to make it transparent to the user, we may not need to receive an error when aggregation options are sent for a non point geometry. Instead, Windshaft could just ignore the aggregation.
The text was updated successfully, but these errors were encountered: