chore(lint): Set up ESLint #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donmccurdy
force-pushed
the
chore/eslint
branch
from
6c44a3f to
efdd862
Compare
jmgaya
approved these changes
Feb 19, 2025
|
|
||
| // TODO: These rules should be re-enabled for all code. | ||
| '@typescript-eslint/ban-ts-comment': 'off', | ||
| }; |
There was a problem hiding this comment.
Thinking out loudly, I think we should start thinking about creating some kind of @carto/eslint-config, because I think codebases should be aligned within these rules, and maintaining only an ESLint Config seems easier, safer, and better, for all of us, WDYT?
Said so, thank you very much for caring about DEV/PROD rules, I think this aligns pretty well with the mess in cloud-native where we disable the same ESLint rules on every test, great job! ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ESLint v9 and configures a linting check for production and non-production code in the repository. Some of the linter rules are looser than would be ideal (allowing implicit 'any', for example) in order to keep the size of the initial PR a bit more manageable.