Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove request as development dependency #28

Open
dgaubert opened this issue May 14, 2020 · 0 comments
Open

Remove request as development dependency #28

dgaubert opened this issue May 14, 2020 · 0 comments

Comments

@dgaubert
Copy link
Contributor

I was added because of tomas/needle#312, as this module is used as a fallback when request is not available in node-pre-gyp (see: https://github.com/mapbox/node-pre-gyp/blob/590da5603bb77df9583bfdc54d05d2267cadb364/lib/install.js#L27-L35).

When fixed we need to remove request from our dependency tree.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dgaubert