Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payment-related features #25

Closed
3 of 4 tasks
Welcius opened this issue Jun 26, 2020 · 2 comments
Closed
3 of 4 tasks

Payment-related features #25

Welcius opened this issue Jun 26, 2020 · 2 comments

Comments

@Welcius
Copy link

Welcius commented Jun 26, 2020

Hello! First and foremost, I have to say that I love your project! That being said, I'd like to propose some interesting features that would make the project more complete:

  • Send a payment to an specific UUID with a new bot.clientCommands.grid.sendPayment method.
  • Subscribe to incoming payments with a new bot.clientEvents.onPaymentReceived.subscribe method.
  • Check your balance using a new bot.clientCommands.grid.checkBalance method.
  • Add the field joinPrice to GroupInviteEvent that indicates the amount of cash required to join the group.

Ideally the sendPayment method would be promise-based to check if the payment was sent properly, or perhaps a new method bot.clientEvents.onPaymentCompleted method to check for that would be better?

Thanks for your work!

@TomMettam
Copy link
Contributor

All implemented - I won't do the "joinPrice" because this is just part of the group invite message string, and the format could change at any time, so it's rather out of scope of this library. If you want to parse this in your application feel free :)

@Welcius
Copy link
Author

Welcius commented Dec 1, 2020

Thank you! This is really helpful :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants