Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sauron-SEM connection #89

Open
odartsi opened this issue May 31, 2024 · 2 comments
Open

Sauron-SEM connection #89

odartsi opened this issue May 31, 2024 · 2 comments
Assignees

Comments

@odartsi
Copy link
Contributor

odartsi commented May 31, 2024

No description provided.

@odartsi odartsi self-assigned this May 31, 2024
@bernardusrendy
Copy link
Collaborator

bernardusrendy commented Jun 17, 2024

so you dont need sauron to test the RPC
you can do it directly in the SEM PC

if you can manage to run all functions in the PhenomDriver class from the PhenomDevice that uses the RPC, that would be great!

because in principle we use the RPC so this can be run easily, but there are few functions that have problems such as ones where they return enum classes like InstrumentMode

basically making unit test for PhenomDevice class, and changing PhenomDriver whenever needed to satisfy RPC limitations (e.g., no enum return, etc.)

you will see the RPC limitations once you run the methods in PhenomDriver through PhenomDevice !

steps (all done in SEM PC):

  1. run the rpc server (server.py) in a gitcmd
  2. add methods in PhenomDevice that runs methods in PhenomDriver
  3. open another gitcmd (Phenomtest or phenomtest environment [delete one of this I guess? why we have two])
  4. use the other gitcmd to instantiate PhenomDevice by importing it from alab_one
    run each methods you added in step number 2

Note: when I say PhenomDriver here is the one in alab_control, and PhenomDevice is in alab_one which uses the PhenomDriver as a self.driver attribute

@odartsi
Copy link
Contributor Author

odartsi commented Jun 26, 2024

sorry, i missed this ticket, I use a new one in #90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants