Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update logic to process validated candidate command to support elastic scaling #4402

Open
Tracked by #3820
axaysagathiya opened this issue Dec 11, 2024 · 0 comments
Open
Tracked by #3820
Labels
C-simple Minor changes changes, no additional research needed. Good first issue/review. good first issue issues that are suitable for first-time contributors. T-enhancement this issue/pr covers improvement of existing functionality.

Comments

@axaysagathiya
Copy link
Contributor

axaysagathiya commented Dec 11, 2024

Issue summary

Validated candidate command is an internal message used within the candidate backing subsystem.

There are three validated candidate commands (enum)

  • No changes are needed in the logic to process Attest and AttestNoPov commands.
  • there are minor changes in the logic to process Second command

Implementation details

modification in a logic to process Second command:

  • Some logic seems to be not required. So remove this code where we compare
    persistedValidationData.ParentHead.Data hash with commitments.HeadData.Data hash.
  • remove the code to update seconded depths in active leaves, which is related to the fragment tree.

Other information and links

Acceptance criteria

@axaysagathiya axaysagathiya added C-simple Minor changes changes, no additional research needed. Good first issue/review. good first issue issues that are suitable for first-time contributors. T-enhancement this issue/pr covers improvement of existing functionality. labels Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-simple Minor changes changes, no additional research needed. Good first issue/review. good first issue issues that are suitable for first-time contributors. T-enhancement this issue/pr covers improvement of existing functionality.
Projects
None yet
Development

No branches or pull requests

1 participant