Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move overseer messages to a subsystems messages package #4409

Open
EclesioMeloJunior opened this issue Dec 14, 2024 · 1 comment
Open

Move overseer messages to a subsystems messages package #4409

EclesioMeloJunior opened this issue Dec 14, 2024 · 1 comment
Labels
C-simple Minor changes changes, no additional research needed. Good first issue/review. good first issue issues that are suitable for first-time contributors. T-implementation this issue/pr is a new feature or functionality.

Comments

@EclesioMeloJunior
Copy link
Member

EclesioMeloJunior commented Dec 14, 2024

Issue summary

  • While designing the statement distribution subsystem I've noticed that it needs to send messages to Candidate Backing subsystems, and after a look into the Candidate Backing it will also need to send messages to Statement Distribution

  • Currently, in Gossamer we have packages contains a filed message.go that contains all the messages the subsystem can receive, and other packages that contains an inner package called messages that holds a file called messages.go that contains the messages.

  • In a case where two subsystems should send messages to each other they need to import the receiving subsystem to be able to instantiate the message and sent, so if all the messages stay in the subsystem package this will create an cyclic import

Implementation details

  • We should use the second approach where the subsystem has an inner package called messages to avoid such case.

Other information and links

Acceptance criteria

[] Move all the messages for each subsystems to the messages pkg

@EclesioMeloJunior EclesioMeloJunior added C-simple Minor changes changes, no additional research needed. Good first issue/review. T-implementation this issue/pr is a new feature or functionality. labels Dec 14, 2024
@EclesioMeloJunior EclesioMeloJunior self-assigned this Dec 14, 2024
@EclesioMeloJunior EclesioMeloJunior changed the title Move subsystems message to message package Move subsystems messages to message package Dec 14, 2024
@EclesioMeloJunior EclesioMeloJunior changed the title Move subsystems messages to message package Move subsystems messages to messages package Dec 16, 2024
@EclesioMeloJunior EclesioMeloJunior changed the title Move subsystems messages to messages package Move subsystems messages to a subsystems messages package Dec 16, 2024
@axaysagathiya axaysagathiya changed the title Move subsystems messages to a subsystems messages package Move overseer messages to a subsystems messages package Dec 16, 2024
@axaysagathiya axaysagathiya added the good first issue issues that are suitable for first-time contributors. label Dec 16, 2024
@haikoschol
Copy link
Contributor

I just came across the file dot/parachain/types/overseer_message.go. I guess it was intended for this purpose. Should we move those types into messages sub-packages inside the subsystems as well (and get rid of the subsystem name prefix)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-simple Minor changes changes, no additional research needed. Good first issue/review. good first issue issues that are suitable for first-time contributors. T-implementation this issue/pr is a new feature or functionality.
Projects
None yet
Development

No branches or pull requests

3 participants