Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Core::initialize_block returned enum value #4412

Open
EclesioMeloJunior opened this issue Dec 16, 2024 · 0 comments
Open

Support Core::initialize_block returned enum value #4412

EclesioMeloJunior opened this issue Dec 16, 2024 · 0 comments
Labels
P-high this should be addressed ASAP. S-babe issues related to block production functionality. T-implementation this issue/pr is a new feature or functionality.
Milestone
Validator MVP

Comments

@EclesioMeloJunior
Copy link
Member

Issue summary

  • The changes are described here in the RFC #13

Implementation details

  • While building the block we should do some runtime calls, and the first one is to Core::initialize_block that changed to return an enum whic should be supported by our host.

Other information and links

Acceptance criteria

[] Implement the RFC
[] Make sure we don't break other runtimes that does not have such behavior
@EclesioMeloJunior EclesioMeloJunior added the T-implementation this issue/pr is a new feature or functionality. label Dec 16, 2024
@P1sar P1sar added S-babe issues related to block production functionality. P-critical this must be fixed immediately or contributors or users will be severely impacted. labels Dec 19, 2024
@P1sar P1sar added this to the Validator MVP milestone Dec 19, 2024
@P1sar P1sar added P-high this should be addressed ASAP. C-complex Complex changes across multiple modules. Possibly will require additional research. and removed P-critical this must be fixed immediately or contributors or users will be severely impacted. C-complex Complex changes across multiple modules. Possibly will require additional research. labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P-high this should be addressed ASAP. S-babe issues related to block production functionality. T-implementation this issue/pr is a new feature or functionality.
Projects
None yet
Milestone
Validator MVP
Development

No branches or pull requests
2 participants
@P1sar @EclesioMeloJunior