Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable URL length limit #5554

Closed
nflaig opened this issue May 26, 2023 · 0 comments · Fixed by #5594
Closed

Configurable URL length limit #5554

nflaig opened this issue May 26, 2023 · 0 comments · Fixed by #5594
Labels
meta-feature-request Issues to track feature requests. scope-interop Issues that fix interop issues between Lodestar and CL, EL or tooling.

Comments

@nflaig
Copy link
Member

nflaig commented May 26, 2023 •
edited
Loading

Problem description

Similar to Lighthouse, we are not exposing a CLI flag to increase the URL lenght limit (maximum header size of the http server)

This will cause issues if Nimbus VC is used with a lot of keys

Solution description

It is possible to increase this limit by passing --max-http-header-size to node process (http.maxHeaderSize) but this option might not be feasible for all users or requires more effort to configure.

It would be better if we expose a CLI flag to achieve this similar to --rest.bodyLimit.

Additional context

See Lighthouse/Nimbus issues
@nflaig nflaig added meta-feature-request Issues to track feature requests. scope-interop Issues that fix interop issues between Lodestar and CL, EL or tooling. labels May 26, 2023
@nflaig nflaig mentioned this issue May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta-feature-request Issues to track feature requests. scope-interop Issues that fix interop issues between Lodestar and CL, EL or tooling.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add option to configure REST API server header limit ChainSafe/lodestar
1 participant
@nflaig