Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Desktop build preview in PRs using a pipeline #1244

Open
juans-chainsafe opened this issue Nov 19, 2024 · 1 comment
Open

Add Desktop build preview in PRs using a pipeline #1244

juans-chainsafe opened this issue Nov 19, 2024 · 1 comment
Assignees
Labels
Priority: P2 Added to issues and PRs relating to a medium severity bugs.

Comments

@juans-chainsafe
Copy link
Contributor

Summary
We want to generate a preview of a Desktop build in the PRs so we know if the build is working and we save time for QA tasks

Suggested features or ways to address the summary

  • Generate the build and display it on the PR so people can access and use it
  • Not sure how this will work for Mac and Desktop, are the same build? or they are different depending on the platform? @kantagara @rob1997 @oleksandrchainsafe @sneakzttv
  • Take in mind, that we need to add the parameters needed for Reown and Web3Auth like project Id in order for them to work

Motivation
This can also be something that we can use to add e2e tests in the build that was generated

Acceptance Criteria

  • Desktop build is generated
  • Build is displayed in the PR
  • Build can be downloaded and install it on the laptop
  • Login and samples works as they will work locally
@juans-chainsafe juans-chainsafe added the Priority: P2 Added to issues and PRs relating to a medium severity bugs. label Nov 19, 2024
@kantagara
Copy link
Contributor

kantagara commented Nov 25, 2024

@juans-chainsafe yeah we would need to generate two different builds on two different machines (they will be run on githubs actions ofc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 Added to issues and PRs relating to a medium severity bugs.
Projects
None yet
Development

No branches or pull requests

3 participants