Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add state to Search component #48

Open
Chalarangelo opened this issue Jul 1, 2019 · 0 comments
Open

Add state to Search component #48

Chalarangelo opened this issue Jul 1, 2019 · 0 comments
Labels
enhancement An improvement to existing code feature Something new
Milestone

Comments

@Chalarangelo
Copy link
Owner

Search renders children.

However, this can cause a few problems, as the developer has to handle state changes by rendering or hiding the Search contents, probably via the onChange event.

It should be refactored to have an internal state, so that Search handles focusing/unfocusing by showing/hiding its results.

On a side note, it might be a good idea to add a clear button or something similar to the component, so that it is more of a unique component and not just another Input.

@Chalarangelo Chalarangelo added feature Something new enhancement An improvement to existing code labels Jul 1, 2019
@Chalarangelo Chalarangelo added this to the v1.0.0 milestone Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement to existing code feature Something new
Projects
None yet
Development

No branches or pull requests

1 participant