Skip to content
This repository has been archived by the owner on Jan 4, 2019. It is now read-only.

Find a way to catch internal ChatExchange exceptions #29

Open
quartata opened this issue Apr 27, 2017 · 3 comments
Open

Find a way to catch internal ChatExchange exceptions #29

quartata opened this issue Apr 27, 2017 · 3 comments
Assignees

Comments

@quartata
Copy link
Member

Currently excepthook is in place on on_msg threads and the WS thread, but if an exception is thrown in ChatExchange internally (such as the dreaded and random ValueError: invalid literal for int() with base 10: 'users') we won't catch that since it's on a different thread.

@quartata quartata self-assigned this Apr 27, 2017
@teward
Copy link
Member

teward commented Apr 27, 2017

This would need a separate handler inside ChatExchange - we could fork our own, but it may be better to have a generic try/catch in ws.py that captures any subthread errors. We don't have global try/catch right now because it hides other errors we might want to catch, but if we can find what lines in standard Smokey call that in CE we might be able to suppress - the problem is that doesn't fix the issue long term and would still cause potential issues elsewhere.

@teward
Copy link
Member

teward commented Apr 27, 2017

note I refer to ws.py and I mean the equivalent here in NG.

@quartata
Copy link
Member Author

quartata commented Apr 27, 2017

Global try/catch wouldn't work since it's in another thread (an internal CE worker). (Otherwise daemon would already take care of it)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants