Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DoResize() function in skoot/usr/Theatre/data/www/Art.sam has hard-coded values. #117

Open
AnthonyHJ opened this issue Sep 7, 2024 · 2 comments

Comments

@AnthonyHJ
Copy link

Current version:

function DoResize() {
     var winOffsetWidth = document.Art.width + 12;
     var winOffsetHeight = document.Art.height + 31;
     window.resizeTo(winOffsetWidth,winOffsetHeight);
 } 

A possible better version of the function would be something like:

function DoResize() {
    var winOffsetWidth = (2 * document.Art.width) - window.innerWidth;
    var winOffsetHeight = (2 * document.Art.height) - window.innerHeight;
    window.resizeTo(winOffsetWidth,winOffsetHeight);
 }

I think that does what it is meant to do.

@ChristopherA
Copy link
Contributor

We don’t have an active maintainer at this point.

Do you want to try this fix out and submit a PR?

I’d also be interested in understanding your interest in using SkotOS is and if I can help?

@AnthonyHJ
Copy link
Author

I'm a web-developer, so my involvement is only tangential. Someone asked me to work out why Orchil was not able to resize windows correctly in Opera and I took a look into it as a favour; the issue turned out to be in SkotOS rather than Orchil, so I thought I'd at least make sure it was documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants