Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion - don't increase plots made count after finding a failure #424

Open
bhorvitz opened this issue Oct 3, 2023 · 1 comment
Open

Comments

@bhorvitz
Copy link

bhorvitz commented Oct 3, 2023

Not something urgent, but it would be convenient if the plots made count did not increase if a plot is removed due to failing check:

Generating plot 9 / 2196: 315cabfb27705e124e8f2ea3be61074a5a7db3c2f65992a71592272dfc863ac6
Plot is OK. It passed the proof threshold of 80.000%
Generating plot 10 / 2196: 4288d67c1217d2fe34dc8e5a6e7d905061b4c448ac8e053f7353abbce68ee8ba
WARNING: Deleting plot '/plots/out/plot-k32-c05-2023-09-30-20-36-4288d67c1217d2fe34dc8e5a6e7d905061b4c448ac8e053f7353abb
ce68ee8ba.plot.tmp' as it is below the proof threshold: 0.760 / 0.800.
Generating plot 11 / 2196: fb57dfec35249608d826dc63d0b82f86f225f97b5a208372283be8f3cdc414ba
Plot is OK. It passed the proof threshold of 80.000%

In this example, we should have made 10 / 2196 again.

@sobertram
Copy link

I think the enhancement would be to add a removed metric and not change the created one. Even though a plot was removed it was also created. So it is accurately showing how many were created. Or maybe instead of removed show a net created. Not sure how that would look. Generating 11/2196 net 10, maybe too much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants