Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rounding of stock prices #5

Open
mayankrasu opened this issue Oct 8, 2018 · 2 comments
Open

Rounding of stock prices #5

mayankrasu opened this issue Oct 8, 2018 · 2 comments

Comments

@mayankrasu
Copy link

The returned bricks have rounded stock prices. Can the rounding be turned off/made optional by any chance? For a stock with lower notional stock price, this rounding can have significant impact on the P&L.

By the way...great job so far.

@ChillarAnand
Copy link
Owner

ChillarAnand commented Oct 9, 2018

Did you try with a brick_size of 0.5 or smaller?

@mayankrasu
Copy link
Author

mayankrasu commented Oct 9, 2018

yes I did. Refer below snapshot for example. Brick size is 0.25. The open, high, low and close prices have been rounded before adding the delta.

  date    open    high     low   close  uptrend

0 2018-10-08 03:55:00 216.75 217.00 216.75 217.00 True
1 2018-10-08 04:05:00 217.00 217.25 217.00 217.25 True
2 2018-10-08 04:15:00 217.00 217.00 216.75 216.75 False
3 2018-10-08 04:40:00 216.75 216.75 216.50 216.50 False
4 2018-10-08 04:40:00 216.50 216.50 216.25 216.25 False

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants