Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data loaders used inside node resolvers do not batch #7635

Open
tomachristian opened this issue Oct 21, 2024 · 0 comments
Open

Data loaders used inside node resolvers do not batch #7635

tomachristian opened this issue Oct 21, 2024 · 0 comments

Comments

@tomachristian
Copy link

Product

Hot Chocolate

Version

14.0.0

Link to minimal reproduction

https://gist.github.com/tomachristian/c523f8d196b76edc4924f8235543f889

Steps to reproduce

After upgrading to the final version of 14 we noticed that all our node resolver fields that use data loaders do not properly batch (it works for all other non-'node' fields). I think I nailed it down to the introduction of this #7556. The node field no longer has the ParallelExecutable flag, so the data loaders do not batch, they just get scheduled immediately.

What is expected?

That upon two node queries in the same request, using the same data loader, would yield a single load inside the data loader (a single SQL query, in our case).

What is actually happening?

Upon two node queries in the same request, using the same data loader, it yields TWO separate loads inside the data loader (two SQL queries, in our case).

Relevant log output

No response

Additional context

No response

@tomachristian tomachristian added the 🐛 bug Something isn't working label Oct 21, 2024
@glen-84 glen-84 removed the 🐛 bug Something isn't working label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants