Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize requests for Bitwarden access manager #12

Open
yannickhilber opened this issue Mar 30, 2023 · 0 comments
Open

Optimize requests for Bitwarden access manager #12

yannickhilber opened this issue Mar 30, 2023 · 0 comments
Labels
bootcamp Good for newcomers

Comments

@yannickhilber
Copy link
Contributor

To store the GroupCollectionAccess group_name field for a collection, we need to perform an additional API request to retrieve the group_name (/public/groups/<group_id>) because the collection API response only gives the group_id.

This request is made for every groups that are assigned to a collection. The same group may be assigned to several collections which means that this API request is redundant.

We could create an dictionary of groups before calling the function get_collection() and lookup the dict to avoid redundant API requests.

@yannickhilber yannickhilber added the bootcamp Good for newcomers label Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bootcamp Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant