Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anvil-renamed items ignore #104

Open
Mosscairn opened this issue Feb 3, 2024 · 1 comment
Open

Anvil-renamed items ignore #104

Mosscairn opened this issue Feb 3, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Mosscairn
Copy link

image
ie, the string for this item is §k§b§lBasic §rTape
The text displays properly in the anvil editor, but when the finished item is collected it reverts to italics again.
image
not exactly sure what's going on there but it would be lovely if that could be fixed.
Thank you!

(using 1.6.1+1.20.1)

@Mosscairn Mosscairn added the bug Something isn't working label Feb 3, 2024
@Hi-ImKyle
Copy link

By default all custom named items are Italic. The reset code does not change that in this case because that's just how Minecraft displays custom names. The anvil showing you the correct formatting for what you would like is unaffected by the Italic part of a custom name.

I have only fixed this in my own colour mod, unfortunately I don't have a PR for this mod to fix it for you.

The fix is just explicitly making the Style of the MutableText/Text always use .withItalic(false) by default.. but I'm unsure if this will fix it for this mod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants