Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Music bug in the entire application #614

Closed
1 task done
ayush-t02 opened this issue Jul 25, 2024 · 16 comments · Fixed by #620
Closed
1 task done

[Bug]: Music bug in the entire application #614

ayush-t02 opened this issue Jul 25, 2024 · 16 comments · Fixed by #620
Assignees
Labels

Comments

@ayush-t02
Copy link
Collaborator

Give a brief about the bug ✍️

Sound on / off is redundant, when you navigate from home to any other page and come back to home page 2 separate music files are being played. when you click on sound off it stops one of them but the other keeps playing

What is the expected behavior? 🤔

one page should be associated with only one sound track and tracks should not leak into other pages

Provide step by step information reproduce the bug 📄

navigate from home to any other page and back to home

Select program in which you are contributing

GSSoC24

Code of Conduct

Copy link

Hey @ayush-t02! 👋

👉 Thanks for opening this issue. We appreciate your contribution and will look into it as soon as possible.
👉 Don’t forget to star our Dot-Box and Follow Us on GitHub
👉 Make sure you join our Discord, we have created separate channels for all projects

@MastanSayyad
Copy link
Contributor

MastanSayyad commented Jul 25, 2024

@ayush-t02 it is happening due to two things:

  • When we redirect to other page it opens in new tab (home page remain active with its music) and that page's music starts to play leading to redundant sound
  • In game interface the sound toggle is not working, the music keeps playing even after clicking on it!

@ayush-t02
Copy link
Collaborator Author

do you want me to assign this issue to you?

@MastanSayyad
Copy link
Contributor

Yes, assign it! @ayush-t02

Copy link

Thank you for your contribution! If you have any questions or need further assistance, feel free to reach out to us on our Discord server: Discord. We have separate channels for all projects. Happy coding! 🚀

Connect with us on social media:

@ayush-t02
Copy link
Collaborator Author

@MastanSayyad music state is still the same on my end alongwith the home screen misaligned

@MastanSayyad
Copy link
Contributor

@MastanSayyad music state is still the same on my end alongwith the home screen misaligned

Home screen was misaligned due to PR #619
in index.html I have only made changes in lets go link

@MastanSayyad
Copy link
Contributor

@ayush-t02 Yes I can see it didnt worked out, on my side it was working fine , I have added error handling in console so I will just check whats the issue, and fix it

@MastanSayyad
Copy link
Contributor

one thing i noticed is that the sound is a little faint as compared to the original sound so it might be a problem with the server loading the bg.mp3 @ayush-t02

image

Error handling console displayed this error, So I will try to fix it! as the code is woking fine the only issue is loading the background music

@ayush-t02
Copy link
Collaborator Author

yup correct

@ayush-t02 ayush-t02 reopened this Jul 25, 2024
@ayush-t02
Copy link
Collaborator Author

I reopened the issue to avoid extra work

@MastanSayyad
Copy link
Contributor

Yeah, good idea, if someone have better solution they can also try it!

@MastanSayyad
Copy link
Contributor

MastanSayyad commented Jul 28, 2024

@ayush-t02 The issue is solved now so you can close this issue!

@ayush-t02
Copy link
Collaborator Author

was this issue fixed by you?

@ayush-t02
Copy link
Collaborator Author

and it still doesn't seem solved on my end

Copy link

Thank you for your contribution! If you have any questions or need further assistance, feel free to reach out to us on our Discord server: Discord. We have separate channels for all projects. Happy coding! 🚀

Connect with us on social media:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants